Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dashes with underscores in RPM version strings. Fixes #393. #395

Merged
merged 1 commit into from Apr 2, 2013

Conversation

@jterrace
Copy link
Contributor

jterrace commented Apr 2, 2013

This makes any build of an RPM file change its version string if it contains dashes, since dashes are not allowed by RPM version strings.

It also changes the dependency list of an RPM. If any of the dependencies have a version string with dashes, the dependency list gets changed to underscores.

jordansissel added a commit that referenced this pull request Apr 2, 2013
Replace dashes with underscores in RPM version strings. Fixes #393.
@jordansissel jordansissel merged commit 6ced253 into jordansissel:master Apr 2, 2013
1 check failed
1 check failed
default The Travis build failed
Details
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Apr 2, 2013

Thanks! I'll add some tests for this as well.

@jterrace

This comment has been minimized.

Copy link
Contributor Author

jterrace commented Apr 2, 2013

np, thanks for fpm!

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014
Replace dashes with underscores in RPM version strings. Fixes jordansissel#393.
prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014
Replace dashes with underscores in RPM version strings. Fixes jordansissel#393.
jordansissel added a commit that referenced this pull request Apr 24, 2015
Replace dashes with underscores in RPM version strings. Fixes #393.
jordansissel added a commit that referenced this pull request Jun 20, 2016
Replace dashes with underscores in RPM version strings. Fixes #393.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.