New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add args for controlling rpm %defattr #428

Merged
merged 2 commits into from May 7, 2013

Conversation

Projects
None yet
2 participants
@phrawzty
Contributor

phrawzty commented May 7, 2013

I found that I always needed to edit the generated RPM spec file in order to set the default file and directory permissions (%defattr) before package generation. This is tedious, so why not allow these to be set via the command-line, along with the extant user and group variables?

Context: this is related, but separate from, issues #142 and #178.

@phrawzty

This comment has been minimized.

Contributor

phrawzty commented May 7, 2013

It occurs to me that I've set the defaults for these to numeric values, whereas the existing behaviour inserts dashes; would it be preferable to preserve said behaviour?

@jordansissel

This comment has been minimized.

Owner

jordansissel commented May 7, 2013

Good question! speaking of which, I'll update the generated rpm spec to include a comment saying such things like "If you are finding yourself always editing this file, please file a ticket and ask for a new feature!"

@jordansissel

This comment has been minimized.

Owner

jordansissel commented May 7, 2013

re: preserving existing behavior; yeah, tendency is to always to do this unless there's strong reasons to break with previous behavior.

jordansissel added a commit that referenced this pull request May 7, 2013

Merge pull request #428 from phrawzty/defattr
add args for controlling rpm %defattr

@jordansissel jordansissel merged commit 096fa0e into jordansissel:master May 7, 2013

1 check failed

default The Travis CI build failed
Details

bobtfish pushed a commit to bobtfish/oxidized-omnibus that referenced this pull request Feb 27, 2014

use upstream fpm-cookery
Upstream already includes the omnibus paths patches.

In addition this fixes rpm packaging issue where RPM spec is generated
with wrong (%defattr) format. Probably related to
jordansissel/fpm#428

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#428 from phrawzty/defattr
add args for controlling rpm %defattr

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#428 from phrawzty/defattr
add args for controlling rpm %defattr

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #428 from phrawzty/defattr
add args for controlling rpm %defattr

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #428 from phrawzty/defattr
add args for controlling rpm %defattr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment