Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make channel-discover optional for custom channels #438

Merged
merged 1 commit into from May 15, 2013

Conversation

@hatt
Copy link
Contributor

hatt commented May 13, 2013

Should fix #437 but I feel it's a bit dirty and lacks any unit tests (along with the rest of the PEAR stuff really.) I based the change on the way the NPM packager works although I handled popen differently as I need it to work in Ruby 1.8.7 for various reasons. Should still be solid and testing hasn't shown any problems.

jordansissel added a commit that referenced this pull request May 15, 2013
make channel-discover optional for custom channels
@jordansissel jordansissel merged commit 1809500 into jordansissel:master May 15, 2013
1 check failed
1 check failed
default The Travis CI build could not complete due to an error
Details
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented May 15, 2013

I defer to your PHP/Pear knowledge! Thank you for this patch :)

Regarding lack of pear tests in fpm; indeed - it's on my todo list to add some, though I will accept any contributions in that area :)

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014
make channel-discover optional for custom channels
prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014
make channel-discover optional for custom channels
jordansissel added a commit that referenced this pull request Apr 24, 2015
make channel-discover optional for custom channels
jordansissel added a commit that referenced this pull request Jun 20, 2016
make channel-discover optional for custom channels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.