New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make debian control tarball use owner and group arguments (gnutar fix) #450

Merged
merged 4 commits into from May 30, 2013

Conversation

Projects
None yet
3 participants
@scalp42
Contributor

scalp42 commented May 22, 2013

This PR is related to #433.

Problem:

If the group doesn't exist, gnutar (1.17) will fail on MacOSX (10.8.3).

Fix:

If on darwin, and --group root is specified, switch to using a numeric GID.

How to replicate the issue:

  $> gnutar --owner root --group root
  gnutar: root: %s: Invalid group (BAD)

  $> gnutar --owner root --group wheel
  gnutar: You must specify one of the `-Acdtrux' options (GOOD)

  $> gnutar --owner root --group 0 --numeric-owner
  gnutar: You must specify one of the `-Acdtrux' options (GOOD)

I merged mmb commit related to #433.

Let me know if more details are needed,

Thanks!

@scalp42

This comment has been minimized.

Contributor

scalp42 commented May 22, 2013

1.8.7 seems to fail with rpm specs.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented May 30, 2013

1.8.7 failures are unrelated to this change.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented May 30, 2013

Re: gnutar failures; the reason for using "root" is because deb wants the owner to be literally "root" (not 0). I'll fiddle with tar on a mac to see what's going on.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented May 30, 2013

Ahha. Figured things out

lintian doesn't complain if the owner is 0/0 it seems.

     safesystem(tar_cmd, "--numeric-owner", "--owner=0", "--group=0", "-zcf",
                 controltar, "-C", control_path, ".")

This seems to keep the same functionality but should now also work on Darwin.

jordansissel added a commit that referenced this pull request May 30, 2013

Merge pull request #450 from AudaxHealthInc/fpm_fix_macos
Make debian control tarball use owner and group arguments (gnutar fix)

@jordansissel jordansissel merged commit b461604 into jordansissel:master May 30, 2013

1 check failed

default The Travis CI build failed
Details

jordansissel added a commit that referenced this pull request May 30, 2013

@scalp42

This comment has been minimized.

Contributor

scalp42 commented May 30, 2013

Sweet thanks @jordansissel

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#450 from AudaxHealthInc/fpm_fix_macos
Make debian control tarball use owner and group arguments (gnutar fix)

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#450 from AudaxHealthInc/fpm_fix_macos
Make debian control tarball use owner and group arguments (gnutar fix)

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #450 from AudaxHealthInc/fpm_fix_macos
Make debian control tarball use owner and group arguments (gnutar fix)

jordansissel added a commit that referenced this pull request Apr 24, 2015

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #450 from AudaxHealthInc/fpm_fix_macos
Make debian control tarball use owner and group arguments (gnutar fix)

jordansissel added a commit that referenced this pull request Jun 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment