New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include build dependencies in Perl lib path for tests #500

Merged
merged 2 commits into from Aug 2, 2013

Conversation

Projects
None yet
2 participants
@hatt
Contributor

hatt commented Jul 26, 2013

This is kinda ugly IMO as the path will get inserted twice due to inheritance or something. I'm not 100% if Module::Build has the same issue as I couldn't get any tests to show one way or the other; I literally couldn't find a module using Build.PL which had test_requires that weren't already installed for me. If it does have the issue, a similar fix is needed.

I also noticed in testing that MakeMaker will run instead of MB in the event of a distribution having both (f.e. Carton). As MB is newer, it probably makes more sense to put that first. Either way, this pull request should solve #490 and I'm going to leave the branch open to see what I can do about #442 and the potential issue in Module::Build.

@hatt

This comment has been minimized.

Contributor

hatt commented Aug 2, 2013

This is probably good for merging now as it fixes both the potential issue in Module::Build and the problem of path precedence allowing system libs to take priority when the path isn't actively set by cpanm. It'd be good if @dnbert and @patcable could take a test run of it though.

jordansissel added a commit that referenced this pull request Aug 2, 2013

Merge pull request #500 from hatt/perl-lib-fix
Include build dependencies in Perl lib path for tests

@jordansissel jordansissel merged commit 04d9f18 into jordansissel:master Aug 2, 2013

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#500 from hatt/perl-lib-fix
Include build dependencies in Perl lib path for tests

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#500 from hatt/perl-lib-fix
Include build dependencies in Perl lib path for tests

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #500 from hatt/perl-lib-fix
Include build dependencies in Perl lib path for tests

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #500 from hatt/perl-lib-fix
Include build dependencies in Perl lib path for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment