Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed for MYMETA files in cpan source #573

Merged
merged 3 commits into from Dec 6, 2013

Conversation

@miked63017
Copy link
Contributor

miked63017 commented Oct 10, 2013

In response to #572

@miked63017

This comment has been minimized.

Copy link
Owner Author

miked63017 commented on 1fc84da Oct 10, 2013

in response to jordansissel#566

@miked63017

This comment has been minimized.

Copy link
Owner Author

miked63017 commented on 2e4110f Oct 11, 2013

in response to jordansissel#571

@miked63017

This comment has been minimized.

Copy link
Contributor Author

miked63017 commented Oct 11, 2013

Should cover:
#572
#571
#566

Tested before and after changes with several packages in each issue.

@@ -75,20 +75,46 @@ class FPM::Package::Python < FPM::Package
# * The path to a setup.py
def input(package)
path_to_package = download_if_necessary(package, version)
if (attributes[:python_pip] and path_to_package.kind_of?(Array))

This comment has been minimized.

Copy link
@jordansissel

jordansissel Oct 29, 2013

Owner

Is this python change intended? Based on the PR description, this PR should only contain cpan changes, right?

This comment has been minimized.

Copy link
@miked63017

miked63017 Oct 29, 2013

Author Contributor

Honestly I could not figure out how to do separate pull requests per
commit. The python change was intentional but I don't think it is ready for
production use based on a few side effects I found. There are two commits
for the cpan source, one for mymeta and one to build from a local dir
instead of always reaching out to download. Both of the cpab changes are
solid as far as I can tell. I can revert the python commit for now if
needed, just let me know. Thanks
On Oct 29, 2013 4:50 PM, "Jordan Sissel" notifications@github.com wrote:

In lib/fpm/package/python.rb:

@@ -75,20 +75,46 @@ class FPM::Package::Python < FPM::Package

* The path to a setup.py

def input(package)
path_to_package = download_if_necessary(package, version)

  • if (attributes[:python_pip] and path_to_package.kind_of?(Array))

Is this python change intended? Based on the PR description, this PR
should only contain cpan changes, right?


Reply to this email directly or view it on GitHubhttps://github.com//pull/573/files#r7294204
.

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Dec 6, 2013

Thanks for the details, and sorry for the slowness in me merging this!

jordansissel added a commit that referenced this pull request Dec 6, 2013
Allowed for MYMETA files in cpan source
@jordansissel jordansissel merged commit 6f51ee9 into jordansissel:master Dec 6, 2013
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Dec 6, 2013

After this merge, 9 tests fail.

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Dec 6, 2013

If I revert 2e4110f, tests pass again. Can you fix that and open a new PR? I only reverted your python change

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014
Allowed for MYMETA files in cpan source
prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014
Allowed for MYMETA files in cpan source
jordansissel added a commit that referenced this pull request Apr 24, 2015
Allowed for MYMETA files in cpan source
jordansissel added a commit that referenced this pull request Jun 20, 2016
Allowed for MYMETA files in cpan source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.