New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Provides section with underscores #591

Merged
merged 6 commits into from Dec 6, 2013

Conversation

Projects
None yet
2 participants
@econnell
Contributor

econnell commented Nov 26, 2013

This pull request fixes a problem with calculating the Provides section of the debian control file when the source package contains an underscore.

For example:

$ fpm -s gem -t deb daemon_controller

generates a control file with the following:

$ dpkg -I rubygem-daemon-controller_1.1.7_all.deb | grep Provides
 Provides: rubygem-daemon_controller

instead of the expected "rubygem-daemon-controller"

jordansissel added a commit that referenced this pull request Dec 6, 2013

Merge pull request #591 from econnell/master
Fix for Provides section with underscores

@jordansissel jordansissel merged commit 4d492a8 into jordansissel:master Dec 6, 2013

jordansissel added a commit that referenced this pull request Dec 6, 2013

Add test coverage for #591
This also required fixing some bugs where FPM::Package::Deb mistakenly
made 'provides' a string (in the tests and in the 'input' method)
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Dec 6, 2013

Thanks for helping improve fpm! I added some test coverage for this as well.

gerbercj pushed a commit to gerbercj/fpm that referenced this pull request Feb 27, 2014

Add test coverage for jordansissel#591
This also required fixing some bugs where FPM::Package::Deb mistakenly
made 'provides' a string (in the tests and in the 'input' method)

gerbercj pushed a commit to gerbercj/fpm that referenced this pull request Mar 11, 2014

Add test coverage for jordansissel#591
This also required fixing some bugs where FPM::Package::Deb mistakenly
made 'provides' a string (in the tests and in the 'input' method)

gerbercj pushed a commit to gerbercj/fpm that referenced this pull request Apr 25, 2014

Add test coverage for jordansissel#591
This also required fixing some bugs where FPM::Package::Deb mistakenly
made 'provides' a string (in the tests and in the 'input' method)

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#591 from econnell/master
Fix for Provides section with underscores

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Add test coverage for jordansissel#591
This also required fixing some bugs where FPM::Package::Deb mistakenly
made 'provides' a string (in the tests and in the 'input' method)

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#591 from econnell/master
Fix for Provides section with underscores

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Add test coverage for jordansissel#591
This also required fixing some bugs where FPM::Package::Deb mistakenly
made 'provides' a string (in the tests and in the 'input' method)

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #591 from econnell/master
Fix for Provides section with underscores

jordansissel added a commit that referenced this pull request Apr 24, 2015

Add test coverage for #591
This also required fixing some bugs where FPM::Package::Deb mistakenly
made 'provides' a string (in the tests and in the 'input' method)

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #591 from econnell/master
Fix for Provides section with underscores

jordansissel added a commit that referenced this pull request Jun 20, 2016

Add test coverage for #591
This also required fixing some bugs where FPM::Package::Deb mistakenly
made 'provides' a string (in the tests and in the 'input' method)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment