don't replace the last dash as that is the release separator #603

Merged
merged 1 commit into from Dec 18, 2013

Conversation

Projects
None yet
2 participants
Contributor

avalanche123 commented Dec 18, 2013

rpm versions can optionally specify releases. neither versions nor releases can have dashes, however version and release are separated with a dash, fixes #601

Owner

jordansissel commented Dec 18, 2013

I feel like the correct behavior is to actually not do anything to the dependency version value (don't muck with the '-' text?)

Maybe?

Contributor

avalanche123 commented Dec 18, 2013

+1 actually

Contributor

avalanche123 commented Dec 18, 2013

updated accordingly

jordansissel added a commit that referenced this pull request Dec 18, 2013

Merge pull request #603 from avalanche123/rpm-version-fix
don't replace the last dash as that is the release separator

@jordansissel jordansissel merged commit 9e8b20f into jordansissel:master Dec 18, 2013

Owner

jordansissel commented Dec 18, 2013

Woo! Thanks for helping improve fpm :)

Contributor

avalanche123 commented Dec 18, 2013

no, thank you sir!

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

Merge pull request #603 from avalanche123/rpm-version-fix
don't replace the last dash as that is the release separator

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request #603 from avalanche123/rpm-version-fix
don't replace the last dash as that is the release separator

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #603 from avalanche123/rpm-version-fix
don't replace the last dash as that is the release separator

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #603 from avalanche123/rpm-version-fix
don't replace the last dash as that is the release separator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment