New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CPAN download URL problems - correct path and use a mirror if specified #614

Merged
merged 2 commits into from Mar 7, 2014

Conversation

Projects
None yet
2 participants
@tjnicholas
Contributor

tjnicholas commented Jan 6, 2014

LockFile::Simple wasn't able to be built because it's download URL wasn't compatible with the hard coded format previously used in cpan.rb - it returned a 404.

I've updated the download function to use another metacpan API call to find the 'archive' string which includes a subdirectory if required.

I've also updated the URL to use the specified mirror if one is specified. This wasn't done previously. The mirror was previously only used when cpanm pulls dependencies.

With the patch I've successfully created packages of IO::Event and DBI which were mentioned in the commit where the URL was changed last time (in addition to LockFile::Simple).

tjnicholas added some commits Jan 6, 2014

Call Metacpan again to get the archive name to downlaod. This may or may
not be in a subdirectory.
Also generate the tarball name from this.

Not using the download_url from metacpan as it is a metacpan URL.

jordansissel added a commit that referenced this pull request Mar 7, 2014

Merge pull request #614 from tjnicholas/cpandownload
Fix CPAN download URL problems - correct path and use a mirror if specified

@jordansissel jordansissel merged commit 72e2846 into jordansissel:master Mar 7, 2014

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Mar 7, 2014

Yay, thanks!

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#614 from tjnicholas/cpandownload
Fix CPAN download URL problems - correct path and use a mirror if specified

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#614 from tjnicholas/cpandownload
Fix CPAN download URL problems - correct path and use a mirror if specified

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #614 from tjnicholas/cpandownload
Fix CPAN download URL problems - correct path and use a mirror if specified

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #614 from tjnicholas/cpandownload
Fix CPAN download URL problems - correct path and use a mirror if specified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment