New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw an error when --deb-compression=gz is passed. #616

Merged
merged 1 commit into from Jan 9, 2014

Conversation

Projects
None yet
3 participants
@EvanKrall
Contributor

EvanKrall commented Jan 9, 2014

Previously, when passing --deb-compression=gz, you'd get

Invalid package configuration: Unknown compression type 'gz' {:level=>:error}

And when passing --deb-compression=gzip, you'd get

ERROR: option '--deb-compression': deb compression value of 'gzip' is invalid. Must be one of gz, bzip2, xz

This makes --deb-compression=gz work happily.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jan 9, 2014

facepalm

jordansissel added a commit that referenced this pull request Jan 9, 2014

Merge pull request #616 from EvanKrall/master
Don't throw an error when --deb-compression=gz is passed.

@jordansissel jordansissel merged commit 84d4377 into jordansissel:master Jan 9, 2014

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jan 10, 2014

Using docker to verify tests pass on CentOS - SOFTWARE INCEPTION.

@tianon

This comment has been minimized.

tianon commented Jan 10, 2014

While you're at it, you should definitely use FPM to create packages for FPM. Not having this seems a little counter-intuitive. (you do drink the koolaid you've made, right?) :)

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jan 11, 2014

@tianon haha, you're totally right! It's actually on my todo list to ship self-contained packages (that include vendored dependencies like Chef and Vagrant do) - the plan currently is to use omnibus to achieve this, which in a delicious instance of recursion, uses fpm itself to produce output after it's done building ;)

<3 open source.

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#616 from EvanKrall/master
Don't throw an error when --deb-compression=gz is passed.

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#616 from EvanKrall/master
Don't throw an error when --deb-compression=gz is passed.

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #616 from EvanKrall/master
Don't throw an error when --deb-compression=gz is passed.

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #616 from EvanKrall/master
Don't throw an error when --deb-compression=gz is passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment