New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to --config-files option description note that it accepts directories #642

Merged
merged 1 commit into from Mar 7, 2014

Conversation

Projects
None yet
4 participants
@vrutsky
Contributor

vrutsky commented Feb 13, 2014

No description provided.

jordansissel added a commit that referenced this pull request Mar 7, 2014

Merge pull request #642 from vrutsky/config_files_doc
Add to --config-files option description note that it accepts directories

@jordansissel jordansissel merged commit a88c70c into jordansissel:master Mar 7, 2014

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Mar 7, 2014

Thanks!

@chrneumann

This comment has been minimized.

chrneumann commented Jun 13, 2014

Does it support directories? I get an error:

Invalid package configuration: Error trying to use '/tmp/package-dir-staging20140613-17428-a02y4y/dist/monsti-0.7.0.dev.master.675/etc' as a config file in the package. Does it exist? {:level=>:error}

(the directory exists)

@rutsky

This comment has been minimized.

Contributor

rutsky commented Jun 14, 2014

@chrneumann It should support.

At least when packaging RPM package, these directories are recursively scanned and their contents are used:

self.config_files.each do |path|

What kind package you are building?

@chrneumann

This comment has been minimized.

chrneumann commented Jun 15, 2014

Sorry for the confusion, I used the wrong path as argument. It should be relative to the root of the package, not relative to $PWD

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#642 from vrutsky/config_files_doc
Add to --config-files option description note that it accepts directories

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#642 from vrutsky/config_files_doc
Add to --config-files option description note that it accepts directories

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #642 from vrutsky/config_files_doc
Add to --config-files option description note that it accepts directories

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #642 from vrutsky/config_files_doc
Add to --config-files option description note that it accepts directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment