New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: Add a option to insert raw Require statements #687

Merged
merged 1 commit into from Nov 7, 2015

Conversation

Projects
None yet
2 participants
@vStone
Contributor

vStone commented Apr 29, 2014

This can be useful to have requirements for different stages.

Examples:

--rpm-add-require 'Requires(post): /usr/sbin/alternatives'
--rpm-add-require 'Requires(preun): /usr/sbin/alternatives'
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jul 24, 2014

hmm, it's not really an 'add-require' if you specify Requires in the value. The rpm book calls this a tag. What about --rpm-tag 'Requires.....' ?

Citation: http://www.rpm.org/max-rpm/s1-rpm-inside-tags.html

Looking at a spec file, the first thing you'll see are a number of lines, all following the same basic format:
something:something-else
The is known as a "tag", because it is used by RPM to name or tag some data.

@vStone

This comment has been minimized.

Contributor

vStone commented Jul 25, 2014

I'll try to run a quick sed -i on the code and update the pull request later today.

@vStone

This comment has been minimized.

Contributor

vStone commented Jul 25, 2014

Rebased + adjusted commit.

rpm: Add a option to insert raw tag statements
This can be useful to have requirements for different stages.

Examples:

    --rpm-tag 'Requires(post): /usr/sbin/alternatives'
    --rpm-tag 'Requires(preun): /usr/sbin/alternatives'

vStone added a commit to vStone/fpm that referenced this pull request Sep 18, 2014

Merged pull request: jordansissel#687: rpm: Add a option to insert ra…
…w Require statements

* pr/687:
  rpm: Add a option to insert raw tag statements

@jordansissel jordansissel added the O(1) label Oct 25, 2014

@jordansissel jordansissel force-pushed the jordansissel:master branch from 7280243 to 4452a23 Oct 25, 2014

@jordansissel jordansissel force-pushed the jordansissel:master branch 2 times, most recently from 715ab62 to 9866c6d Apr 24, 2015

jordansissel added a commit that referenced this pull request Nov 7, 2015

Merge pull request #687 from vStone/feature/rpm-custom-requires
rpm: Add a option to insert raw Require statements

@jordansissel jordansissel merged commit 66e0501 into jordansissel:master Nov 7, 2015

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Nov 7, 2015

Thanks for your work revising this patch <3

Merged!

@vStone vStone deleted the vStone:feature/rpm-custom-requires branch Nov 13, 2015

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #687 from vStone/feature/rpm-custom-requires
rpm: Add a option to insert raw Require statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment