Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue where gem-version-bins is enabled but there are no binaries #688

Merged

Conversation

@vStone
Copy link
Contributor

vStone commented Apr 29, 2014

No description provided.

vStone added a commit to vStone/fpm that referenced this pull request May 2, 2014
…on-bins is enabled but there are no binaries

See jordansissel#688 for more information

* pr/688:
  Updated the example gem with as little changes as possible
  Added tests. Rebuild of example-1.0.0.gem required though
  Fixes an issue where gem-version-bins is enabled but there are no binaries
vStone added a commit to vStone/fpm that referenced this pull request May 6, 2014
…on-bins is enabled but there are no binaries

See jordansissel#688 for more information

* pr/688:
  Updated the example gem with as little changes as possible
  Added tests. Rebuild of example-1.0.0.gem required though
  Fixes an issue where gem-version-bins is enabled but there are no binaries
vStone added a commit to vStone/fpm that referenced this pull request May 6, 2014
…on-bins is enabled but there are no binaries

See jordansissel#688 for more information

* pr/688:
  Updated the example gem with as little changes as possible
  Added tests. Rebuild of example-1.0.0.gem required though
  Fixes an issue where gem-version-bins is enabled but there are no binaries
vStone added 3 commits Apr 29, 2014
checksums.yaml.gz has been stripped as in the current gem.

Changes:

```diff
diff --git a/spec/fixtures/gem/example/example-1.0.gem b/spec/fixtures/gem/example/example-1.0.gem
index 0241779..9238a4a 100644
--- a/spec/fixtures/gem/example/example-1.0.gem
+++ b/spec/fixtures/gem/example/example-1.0.gem
@@ -46,10 +46,12 @@ dependencies:
         version: '0'
 description: sample description
 email: sample email
-executables: []
+executables:
+- example
 extensions: []
 extra_rdoc_files: []
-files: []
+files:
+- bin/example
 homepage: http://sample-url/
 licenses: []
 post_install_message:
@@ -78,3 +80,5 @@ test_files: []
 has_rdoc:
 ============== checksums =============
 =============== files ================
+bin/example
+#!/usr/bin/env ruby

```

See http://vstone.eu/diffing-gems-in-git/
@vStone

This comment has been minimized.

Copy link
Contributor Author

vStone commented Jun 10, 2014

Rebased on current master.

vStone added a commit to vStone/fpm that referenced this pull request Jun 11, 2014
…on-bins is enabled but there are no binaries

See https://github.com/jordansissel/fpm#688 for more information

* pr/688:
  Updated the example gem with as little changes as possible
  Added tests. Rebuild of example-1.0.0.gem required though
  Fixes an issue where gem-version-bins is enabled but there are no binaries
vStone added a commit to vStone/fpm that referenced this pull request Jun 11, 2014
…on-bins is enabled but there are no binaries

See jordansissel#688 for more information

* pr/688:
  Updated the example gem with as little changes as possible
  Added tests. Rebuild of example-1.0.0.gem required though
  Fixes an issue where gem-version-bins is enabled but there are no binaries
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Jul 24, 2014

(facepalm)

jordansissel added a commit that referenced this pull request Jul 24, 2014
Fixes an issue where gem-version-bins is enabled but there are no binaries
@jordansissel jordansissel merged commit 7aed7e8 into jordansissel:master Jul 24, 2014
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Jul 24, 2014

Thanks!

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014
…ns_with_no_bins

Fixes an issue where gem-version-bins is enabled but there are no binaries
prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014
…ns_with_no_bins

Fixes an issue where gem-version-bins is enabled but there are no binaries
jordansissel added a commit that referenced this pull request Apr 24, 2015
Fixes an issue where gem-version-bins is enabled but there are no binaries
jordansissel added a commit that referenced this pull request Jun 20, 2016
Fixes an issue where gem-version-bins is enabled but there are no binaries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.