New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unset CPAN metadata fields #712

Merged
merged 1 commit into from Jun 18, 2014

Conversation

Projects
None yet
2 participants
@mlafeldt
Contributor

mlafeldt commented Jun 2, 2014

Otherwise this can happen:

$ fpm -t deb -s cpan --verbose 'Lingua::JA::Romanize::Japanese'
Asking metacpan about a module {:module=>"Lingua::JA::Romanize::Japanese", :level=>:info}
Downloading perl module {:distribution=>"Lingua-JA-Romanize-Japanese", :version=>nil, :level=>:info}
Setting package name from 'name' {:name=>"Lingua-JA-Romanize-Japanese", :level=>:info}
/usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/lib/fpm/package/cpan.rb:86:in `input': undefined method `join' for nil:NilClass (NoMethodError)
    from /usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/lib/fpm/command.rb:299:in `block in execute'
    from /usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/lib/fpm/command.rb:298:in `each'
    from /usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/lib/fpm/command.rb:298:in `execute'
    from /usr/lib/ruby/gems/1.9.1/gems/clamp-0.6.3/lib/clamp/command.rb:67:in `run'
    from /usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/lib/fpm/command.rb:449:in `run'
    from /usr/lib/ruby/gems/1.9.1/gems/clamp-0.6.3/lib/clamp/command.rb:125:in `run'
    from /usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/bin/fpm:8:in `<top (required)>'
    from /usr/bin/fpm:23:in `load'
    from /usr/bin/fpm:23:in `<main>'
Ignore unset CPAN metadata fields
Otherwise this can happen:

    $ fpm -t deb -s cpan --verbose 'Lingua::JA::Romanize::Japanese'
    Asking metacpan about a module {:module=>"Lingua::JA::Romanize::Japanese", :level=>:info}
    Downloading perl module {:distribution=>"Lingua-JA-Romanize-Japanese", :version=>nil, :level=>:info}
    Setting package name from 'name' {:name=>"Lingua-JA-Romanize-Japanese", :level=>:info}
    /usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/lib/fpm/package/cpan.rb:86:in `input': undefined method `join' for nil:NilClass (NoMethodError)
	    from /usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/lib/fpm/command.rb:299:in `block in execute'
	    from /usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/lib/fpm/command.rb:298:in `each'
	    from /usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/lib/fpm/command.rb:298:in `execute'
	    from /usr/lib/ruby/gems/1.9.1/gems/clamp-0.6.3/lib/clamp/command.rb:67:in `run'
	    from /usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/lib/fpm/command.rb:449:in `run'
	    from /usr/lib/ruby/gems/1.9.1/gems/clamp-0.6.3/lib/clamp/command.rb:125:in `run'
	    from /usr/lib/ruby/gems/1.9.1/gems/fpm-1.1.0/bin/fpm:8:in `<top (required)>'
	    from /usr/bin/fpm:23:in `load'
	    from /usr/bin/fpm:23:in `<main>'
@mlafeldt

This comment has been minimized.

Contributor

mlafeldt commented Jun 14, 2014

@jordansissel Any chance this bug fix gets merged soon?

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jun 14, 2014

Will try to do ASAP!

On Saturday, June 14, 2014, Mathias Lafeldt notifications@github.com
wrote:

@jordansissel https://github.com/jordansissel Any chance this bug fix
gets merged soon?


Reply to this email directly or view it on GitHub
#712 (comment).

jordansissel added a commit that referenced this pull request Jun 18, 2014

@jordansissel jordansissel merged commit b5104f2 into jordansissel:master Jun 18, 2014

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jun 18, 2014

haven't tested, but the code looks fine to me. Presence, but nil, or missing, on hash[] returns nil, so this should be OK.

@mlafeldt

This comment has been minimized.

Contributor

mlafeldt commented Jun 18, 2014

Thanks, Jordan!

@mlafeldt mlafeldt deleted the mlafeldt:cpan-metadata-nil branch Jun 18, 2014

@mlafeldt

This comment has been minimized.

Contributor

mlafeldt commented Jun 18, 2014

Now looking forward to a new gem release. :)

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #712 from mlafeldt/cpan-metadata-nil
Ignore unset CPAN metadata fields

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #712 from mlafeldt/cpan-metadata-nil
Ignore unset CPAN metadata fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment