New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --rpm-verbatim-gem-dependencies flag #724

Merged
merged 1 commit into from Jun 18, 2014

Conversation

Projects
None yet
1 participant
@jordansissel
Owner

jordansissel commented Jun 18, 2014

This should help folks who want the old-style gem-rpm conversions

  • with this flag, old behavior: rubygem-name
  • without flag, default behavior: rubygem(name)

The 'default' behavior has been this behavior since 0.4.23 for most
users.
If you changed the package name prefix via --gem-package-prefix or
--gem-package-name-prefix then this behavior was broken.
It was fixed in #585.

But, I don't want folks relying on old behavior to be screwed
when that behavior mysteriously vanishes! This should be a good
enough work around for now.

Reported by Ryan Doherty via the fpm-users mailing list.

Add --rpm-verbatim-gem-dependencies flag
This should help folks who want the old-style gem-rpm conversions
* with this flag, old behavior: rubygem-name
* without flag, default behavior: rubygem(name)

The 'default' behavior has been this behavior since 0.4.23 for most
users.
If you changed the package name prefix via --gem-package-prefix or
--gem-package-name-prefix then this behavior was broken.
It was fixed in #585.

But, I don't want folks relying on old behavior to be screwed
when that behavior mysteriously vanishes! This should be a good
enough work around for now.

Reported by Ryan Doherty via the fpm-users mailing list.

jordansissel added a commit that referenced this pull request Jun 18, 2014

Merge pull request #724 from jordansissel/new-flag/rpm-verbatim-gem-d…
…ependencies

Add --rpm-verbatim-gem-dependencies flag

@jordansissel jordansissel merged commit 1cc939b into master Jun 18, 2014

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#724 from jordansissel/new-flag/rpm-ve…
…rbatim-gem-dependencies

Add --rpm-verbatim-gem-dependencies flag

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#724 from jordansissel/new-flag/rpm-ve…
…rbatim-gem-dependencies

Add --rpm-verbatim-gem-dependencies flag

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #724 from jordansissel/new-flag/rpm-verbatim-gem-d…
…ependencies

Add --rpm-verbatim-gem-dependencies flag

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #724 from jordansissel/new-flag/rpm-verbatim-gem-d…
…ependencies

Add --rpm-verbatim-gem-dependencies flag

@josegonzalez josegonzalez deleted the new-flag/rpm-verbatim-gem-dependencies branch Nov 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment