New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPAN test and sandboxing fixes #752

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@hatt
Contributor

hatt commented Aug 7, 2014

As discussed in #515 and #748, make sandboxing optional for packaging with system dependencies. This doesn't fix the core issue with RHEL and derivatives, but it does allow users to not install every dependency if they want a build to use system installed modules.

Up til now, --cpan-test would skip tests when told to test and then run them when told not to. That was bad logic on my part I think, so this reverses the behavior and makes it do what a user would expect.

@jordansissel jordansissel added the O(1) label Oct 25, 2014

@jordansissel jordansissel force-pushed the jordansissel:master branch from 7280243 to 4452a23 Oct 25, 2014

@satoshi

This comment has been minimized.

satoshi commented Jan 23, 2015

@jordansissel is there a chance this pull request can be merged? @hatt has done some wonderful work on this and I'd like to see it incorporated into master.

@jordansissel jordansissel force-pushed the jordansissel:master branch 2 times, most recently from 715ab62 to 9866c6d Apr 24, 2015

@jordansissel

This comment has been minimized.

Owner

jordansissel commented May 7, 2015

+1 on the idea, sorry for the delays. @hatt, can you rebase against master? I'll work on merging after that.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented May 7, 2015

Actually, I May be able to patch this in by hand now.

@hatt

This comment has been minimized.

Contributor

hatt commented May 14, 2015

@jordansissel sorry, I just saw comment now, thanks for doing that for me!

jordansissel added a commit that referenced this pull request Jun 20, 2016

make sandboxing non-core modules optional
This adds flag --cpan-sandbox-non-core.

Closes #752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment