New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RakeTask #756

Merged
merged 2 commits into from Nov 7, 2015

Conversation

Projects
None yet
3 participants
@pstengel
Contributor

pstengel commented Aug 13, 2014

This allows you to easily use fpm in a Rakefile without a bunch of backticks or other non-Ruby ugliness. For example, given a Rakefile:

require "fpm/rake_task"

FPM::RakeTask.new(:awesome_pkg, :source => :dir, :target => :tar) do |pkg|
  pkg.args = %w(bin/)
  pkg.verbose = true
  pkg.config_files = %w(foo bar)
end

Run rake awesome_pkg:

Created package {:path=>"awesome_pkg.tar"}
@neoice

This comment has been minimized.

neoice commented Aug 14, 2014

this is relevant to my interests :D

@jordansissel jordansissel added the O(1) label Oct 25, 2014

class FPM::RakeTask < Rake::TaskLib
attr_reader :options
def initialize(*args, source:, target:, directory: ".", &block)

This comment has been minimized.

@jordansissel

jordansissel Oct 25, 2014

Owner

this uses ruby's keyword args and we can't do this in fpm because I'm committing to supporting back to Ruby 1.8.7

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Oct 25, 2014

Would you mind adding tests for this somehow?

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Oct 25, 2014

Otherwise, +1 on this idea.

@jordansissel jordansissel force-pushed the jordansissel:master branch from 7280243 to 4452a23 Oct 25, 2014

@jordansissel jordansissel force-pushed the jordansissel:master branch 2 times, most recently from 715ab62 to 9866c6d Apr 24, 2015

@pstengel

This comment has been minimized.

Contributor

pstengel commented May 16, 2015

@jordansissel: Just pushed a commit that makes it 1.8.7 compatible and adds specs.

jordansissel added a commit that referenced this pull request Nov 7, 2015

@jordansissel jordansissel merged commit c70238b into jordansissel:master Nov 7, 2015

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Nov 7, 2015

Eyeballed the code - looks good! Thank you much :)

jordansissel added a commit that referenced this pull request Jun 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment