Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check first for Build.PL, then for Makefile.PL #787

Merged
merged 1 commit into from Oct 16, 2014

Conversation

@djhaskin987
Copy link
Contributor

djhaskin987 commented Oct 16, 2014

This pull request essentially just flips the order in which we look for Build.PL or Makefile.PL, since some Module::Build builds include both for compatibility reasons, and when we run our code on the compatibility version of Makefile.PL, errors are caused. Associated with #786 .

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Oct 16, 2014

LGTM.

jordansissel added a commit that referenced this pull request Oct 16, 2014
Check first for Build.PL, then for Makefile.PL
@jordansissel jordansissel merged commit 37ae614 into jordansissel:master Oct 16, 2014
prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014
Check first for Build.PL, then for Makefile.PL
prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014
Check first for Build.PL, then for Makefile.PL
@djhaskin987 djhaskin987 deleted the djhaskin987:feature/786 branch Feb 2, 2015
jordansissel added a commit that referenced this pull request Apr 24, 2015
Check first for Build.PL, then for Makefile.PL
jordansissel added a commit that referenced this pull request Jun 20, 2016
Check first for Build.PL, then for Makefile.PL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.