New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify if RPM triggerindex is valid #802

Merged
merged 1 commit into from Nov 7, 2014

Conversation

Projects
None yet
3 participants
@xelwarto
Contributor

xelwarto commented Nov 6, 2014

Quick and dirty fix for issue #801

The code added for RPM triggers assumes that an RPM input would always have a trigger which is not the case.

@makushimu

This comment has been minimized.

Contributor

makushimu commented Nov 6, 2014

I wrote the offending code, and your fix does work.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Nov 7, 2014

@makushimu Thanks for confirming!

I'd love to have a test case for this. Thoughts?

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Nov 7, 2014

@xelwarto thanks much for fixing this :)

@makushimu

This comment has been minimized.

Contributor

makushimu commented Nov 7, 2014

@jordansissel I'm writing test cases right now for this.
Should be done shortly.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Nov 7, 2014

@makushimu aww, you're the best! ❤️

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Nov 7, 2014

Given @makushimu's 👍 and the testing being worked on, I'll merge this.

Thanks so much!

jordansissel added a commit that referenced this pull request Nov 7, 2014

Merge pull request #802 from xelwarto/master
Verify if RPM triggerindex is valid

@jordansissel jordansissel merged commit 9b199b4 into jordansissel:master Nov 7, 2014

@makushimu makushimu referenced this pull request Nov 7, 2014

Closed

Adds RPM input spec test #804

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#802 from xelwarto/master
Verify if RPM triggerindex is valid

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#802 from xelwarto/master
Verify if RPM triggerindex is valid

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #802 from xelwarto/master
Verify if RPM triggerindex is valid

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #802 from xelwarto/master
Verify if RPM triggerindex is valid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment