Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up debian maintenance script templates #836

Merged
merged 3 commits into from Mar 6, 2015

Conversation

@SpikesDivZero
Copy link

SpikesDivZero commented Jan 22, 2015

These templates are only used when --before-upgrade and --after-upgrade are used.

Wesley Spikes added 3 commits Jan 22, 2015
These scripts are only used when before/after-upgrade options are
provided to fpm.
Instead, we use the null operator here. Tested in both dash
and bash.
If you invoke fpm with --before-upgrade, but not --before-install, then
the resultant before_install function becomes an empty function, which
bash/dash do not allow. (Syntax errors) This same problem applies to the
after flags. To avoid this, we'll insert a null statement if there's no
install script specified.

We don't need to do this for the (before|after)_upgrade functions, since
the time these templates are used is when --(before|after)-upgrade is
specified.
@mrijke

This comment has been minimized.

Copy link

mrijke commented Mar 6, 2015

Would be nice to see this merged, got bit by it today.

jordansissel added a commit that referenced this pull request Mar 6, 2015
Fix up debian maintenance script templates
@jordansissel jordansissel merged commit 36f90c2 into jordansissel:master Mar 6, 2015
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Mar 6, 2015

@mrijke thanks for the poke, sorry about losing track of this. <3

@SpikesDivZero

This comment has been minimized.

Copy link
Author

SpikesDivZero commented Mar 8, 2015

Thanks @jordansissel and @mrijke! :)

@SpikesDivZero SpikesDivZero deleted the SpikesDivZero:deb-maint-scripts branch Mar 8, 2015
jordansissel added a commit that referenced this pull request Apr 24, 2015
Fix up debian maintenance script templates
jordansissel added a commit that referenced this pull request Jun 20, 2016
Fix up debian maintenance script templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.