Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[no-]cpan-test now works as advertised #853

Closed
wants to merge 6 commits into from

Conversation

@tomeon
Copy link

tomeon commented Feb 11, 2015

There was a missing ! in front of attributes[:cpan_test], such that the -n (no test) flag was passed to cpanm if and only if attributes[:cpan_test] was true. This inverts the proper logic: cpanm should skip tests if and only if attributes[:cpan_test] is false.

Matt Schreiber added 6 commits Feb 10, 2015
in addition to whatever it could glean from {MY,}META.{json,yml}.
only if attributes[:cpan_test] is false
because the target module has already been downloaded manually, and there shouldn't
be any need to download (and possibly test) it again
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Apr 10, 2015

This patch makes a bunch of whitespace changes :\

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Apr 10, 2015

I was able to merge this with some git trickery:

% git diff -w master..pull/853 | patch -p1
% git commit -a --author="Matt Schreiber <EMAIL>"

(The author info was taken from the git log from the PR)

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Apr 10, 2015

Merged! Thank you :)

jordansissel added a commit that referenced this pull request Apr 24, 2015
Now '-n' (no test) flag passed to cpanm only if attributes[:cpan_test] is false

Also, added '--installdeps' to cpanm_flags because the target module has
already been downloaded manually, and there shouldn't be any need to
download (and possibly test) it again

Closes #853
@tomeon tomeon deleted the tomeon:cpan-test-flag branch Aug 9, 2015
jordansissel added a commit that referenced this pull request Jun 20, 2016
Now '-n' (no test) flag passed to cpanm only if attributes[:cpan_test] is false

Also, added '--installdeps' to cpanm_flags because the target module has
already been downloaded manually, and there shouldn't be any need to
download (and possibly test) it again

Closes #853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.