Adds gem prefix and safesystem #88

Merged
merged 3 commits into from Aug 20, 2011

Conversation

Projects
None yet
2 participants
Contributor

tabletcorry commented Aug 2, 2011

I think both of the commit messages speak for themselves. I have been using the gem prefix commit in production for a few days, and it works fine.

The safesystem call is only very lightly tested. Pull with more caution.

Corry Haines and others added some commits Jul 28, 2011

@tabletcorry Corry Haines Add --gem-package-prefix option
Allows the prefix of packages to change to a user specified value.

Useful if you do not want to conflict with other rubygem packages,
or want to install to a special ruby instance

Fixes #84
f284420
@tabletcorry tabletcorry Add "safesystem" function
Basically, its a replacement for system. If the command fails, then
it raises an exception and prints out the entire command that was
attempted.

This will prevent issues where fpm finished (with return code 0) and
produces an artifact with real size (>0 bytes) but the artifact
is worthless as it contains nothing.

Fixes #86
bdfee82
Contributor

tabletcorry commented Aug 15, 2011

On the testing side, I have been using FPM with both of these patches for a few week now with no issues.

Owner

jordansissel commented Aug 16, 2011

cool :)

I'm trying to find some time to pul lin lots of pending patches, test, and release a new fpm this week.

@tabletcorry tabletcorry Add --python-package-prefix option
Allows the prefix of packages to change to a user specified value.

Useful if you do not want to conflict with other python packages,
or want to install to a special ruby instance
01bda52
Contributor

tabletcorry commented Aug 18, 2011

Yeah... probably not the right way to do this, since I basically copied the code over.

But, I really don't know ruby well, so generalizing this would be hard. Maybe next time.

jordansissel merged commit bd346e7 into jordansissel:master Aug 20, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment