New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improved abort-install and abort-remove #887

Merged
merged 1 commit into from Apr 10, 2015

Conversation

Projects
None yet
2 participants
@djhaskin987
Contributor

djhaskin987 commented Apr 10, 2015

This further improves the postinstall and preremoval scripts' correctness for debian packages when --*-upgrade arguments are used. See #661

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Apr 10, 2015

Eyeballing it - looks good to me. I haven't tested, though. I wish for automated tests, but this may be hard to test right now.

Merging!

jordansissel added a commit that referenced this pull request Apr 10, 2015

Merge pull request #887 from djhaskin987/feature/correct-upgrade-scri…
…pt-cases

Add improved abort-install and abort-remove

@jordansissel jordansissel merged commit 0bd18ce into jordansissel:master Apr 10, 2015

@djhaskin987

This comment has been minimized.

Contributor

djhaskin987 commented Apr 10, 2015

I did a small smoke test on my work to make sure the resultant script didn't barf :)

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Apr 10, 2015

@djhaskin987 I trust you :)

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Apr 10, 2015

@djhaskin987 thanks for helping make fpm more awesome!

@djhaskin987 djhaskin987 deleted the djhaskin987:feature/correct-upgrade-script-cases branch Apr 10, 2015

@djhaskin987

This comment has been minimized.

Contributor

djhaskin987 commented Apr 10, 2015

My pleasure. It's a great tool @jordansissel !

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #887 from djhaskin987/feature/correct-upgrade-scri…
…pt-cases

Add improved abort-install and abort-remove

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #887 from djhaskin987/feature/correct-upgrade-scri…
…pt-cases

Add improved abort-install and abort-remove
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment