Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.fpm parsing: separate options and arguments and add FPMOPTS handling #977

Merged
merged 2 commits into from Nov 7, 2015

Conversation

@mildred
Copy link
Contributor

mildred commented Aug 11, 2015

Allow arguments in .fpm files, old behaviour put those arguments in the middle of the command line, and further options were not recognized. Fix issue #976

Also, add optional default arguments handling from the FPMOPTS environment variable. This allows default arguments to be specified in regard to the .fpm file. This could be useful for a build bot that can specify a default version number (git revision) in case the .fpm file doesn't specify it.

mildred added 2 commits Aug 11, 2015
Allow arguments in .fpm files, old behaviour put those arguments in the
middle of the command line, and further options were not recognized.
Fix issue #976
This allows specifying default arguments that can be overriden by the
.fpm file.
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Nov 7, 2015

I like both ideas. I haven't tested this, but the code looks ok to me :)

Thank you :)

jordansissel added a commit that referenced this pull request Nov 7, 2015
.fpm parsing: separate options and arguments and add FPMOPTS handling
@jordansissel jordansissel merged commit 95599f1 into jordansissel:master Nov 7, 2015
jordansissel added a commit that referenced this pull request Jun 20, 2016
.fpm parsing: separate options and arguments and add FPMOPTS handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.