Version: Bump both esy.json and package.json versions to 1.2.2 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing #21 , I saw that the version was confusingly being reported as
1.1.1byesy ls-builds -T- even though I had the up-to-date bits.I saw that I missed updating the version in
esy.json, so esy was reporting that version as opposed to thepackage.json. I wonder if there is some way we could warn about this situation in the future?Sorry about the churn here @jordwalke !
FYI, I already published this
1.2.2version so that no one would hit a confusing version number situation withesy.