add Koin and move apollo sqllite cache code to shared module #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Dec 28, 2021
| @@ -49,6 +43,7 @@ sealed class Screen(val title: String) { | |||
| object Lists : Screen("Lists") | |||
| } | |||
|
|
|||
| @OptIn(ExperimentalWearMaterialApi::class) | |||
There was a problem hiding this comment.
Was trying to avoid this with the opt-in in build.gradle. Not sure why it's not working in AndroidStudio? Maybe 7.0.4 vs 7.1.0-beta?
But builds work.
There was a problem hiding this comment.
Yeah, I wasn't sure either why I was still getting error for that here.....using Android Studio Arctic Fox fwiw
|
That's really nice, thanks for the cleanup. |
|
I broke some of the test stuff doing this which I'll fix in next PR....that needed overhaul anyway and going to stat using new standard Kotlinx Coroutines runTest() now that it's available in v1.6 |
|
The thing I was tempted to explore was using the normalization cache to make detail pages effectively free. Part of why I wanted to make sure we have cached results. |
|
Yeah, I've done something along same lines in another repo.. It still does
query for detail page but should come from cache.
…On Tue 28 Dec 2021, 17:19 Yuri Schimke, ***@***.***> wrote:
The thing I was tempted to explore was using the normalization cache to
make detail pages effectively free. Part of why I wanted to make sure we
have cached results.
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABRHXB6IUQDO3SZ2MOIT3UTHWSVANCNFSM5K4MA4AA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.