New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony messenger implementation #132
Conversation
e45f59c
to
3ba8f07
Compare
@jorge07 Did You know how resolve problem with tests? |
Hi @cv65kr here the issue:
It's travis. I'm going to move to github actions asap. BTW thanks for the contribution looks great |
I fixed docker issue yesterday, but there is a problem about tests which I describe in PR description. If You look at
That's service are aliases for message buses, but this generate exceptions like below.
Did You have any idea how resolve this problem? |
hey @cv65kr just migrated to github actions as are way faster. Can you rebase please? |
I think you need to define this services as public in the services_test.yaml |
49ee33d
to
79b5074
Compare
Rebased.
I tried this but not working. |
Awesome work here @cv65kr. Tests are failing due to depreciation but feel free to edit phpunit config to avoid this depreciations for now. We can address it in another PR along with the symfony 5 migration |
One last question that I've regarding this symfony messenger switch is if we still need sncrabbitmq |
For now yes, currently is related with Broadway stuff. Green light from GA 👍 |
LGTM Will do a full qa this night and if all goes well will finally merge. Once again. @cv65kr thanks for the great work here. Once merged I'll raise some issues to remove snc redis and have a bridge from Broadway to messenger, and another issue to start the v5 migration (may I rename the repository 😂) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just have a few questions and suggestions.
This PR contains: