Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Gateway IntegrationResponse header support #70

Merged
merged 1 commit into from Apr 6, 2017

Conversation

@elkelk
Copy link
Contributor

@elkelk elkelk commented Jul 11, 2016

This adds support for static and dynamic IntegrationResponse headers as specified here: http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apitgateway-method-integration-integrationresponse.html

The PR includes a CORS example and documentation for parameters within the Integration Response section.

I dug into the tests a bit, but didn't see an easy way to insert coverage. I'd love any direction/suggestions for adding test coverage.

#68

@elkelk elkelk mentioned this pull request Jul 11, 2016
@elkelk elkelk force-pushed the elkelk:master branch from 637bbce to 80cb3ef Jul 11, 2016
@avengerpenguin
Copy link

@avengerpenguin avengerpenguin commented Sep 13, 2016

+1 for this for me. Is there anything I can do to help get it in?

@ahl
Copy link
Contributor

@ahl ahl commented Oct 6, 2016

another +1 from me: I ended up implementing the same thing (here: #107), not realizing that this work had already been done. It would be great to see this accepted.

@ahl ahl mentioned this pull request Oct 6, 2016
@micahwedemeyer
Copy link

@micahwedemeyer micahwedemeyer commented Oct 7, 2016

👍 CORS support is super important for a huge percentage of projects that would use Lambda.

@DaRizat
Copy link

@DaRizat DaRizat commented Jan 7, 2017

+1 Any update on when this might be available?

@YoavGivati
Copy link

@YoavGivati YoavGivati commented Jan 19, 2017

+1. Would help a lot with new engineers not having to install from the src just to use this critical fix.

Starting to get concerned that it's been over 3 months since the last PR was merged in.

cc @jorgebastida

@jorgebastida
Copy link
Owner

@jorgebastida jorgebastida commented Apr 6, 2017

Sorry for the long delay! This looks amazing :) Thank you all for you patience

@jorgebastida jorgebastida merged commit 3f393ab into jorgebastida:master Apr 6, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants