Add API Gateway IntegrationResponse header support #70
+49
−2
Conversation
Closed
|
+1 for this for me. Is there anything I can do to help get it in? |
|
another +1 from me: I ended up implementing the same thing (here: #107), not realizing that this work had already been done. It would be great to see this accepted. |
|
|
|
+1 Any update on when this might be available? |
|
+1. Would help a lot with new engineers not having to install from the src just to use this critical fix. Starting to get concerned that it's been over 3 months since the last PR was merged in. |
|
Sorry for the long delay! This looks amazing :) Thank you all for you patience |
jorgebastida
merged commit 3f393ab
into
jorgebastida:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This adds support for static and dynamic IntegrationResponse headers as specified here: http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apitgateway-method-integration-integrationresponse.html
The PR includes a CORS example and documentation for parameters within the Integration Response section.
I dug into the tests a bit, but didn't see an easy way to insert coverage. I'd love any direction/suggestions for adding test coverage.
#68