Add GitLab support #658
Merged
Add GitLab support #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the possibility to add plugins from gitlab. Resolves jorgebucaran#657.
Even though this did work, it's not correct. This makes the URL fully correct.
README.md
Outdated
Comment on lines
34
to
39
| To install a plugin from GitLab, prefix `gitlab.com/`. | ||
|
|
||
| ```console | ||
| fisher install gitlab.com/ainmosni/fish-aws | ||
| ``` | ||
|
|
There was a problem hiding this comment.
@ainmosni If you can turn this into one sentence and put it after a > (we don't need the example), then I'd be happy to include this in the README.
There was a problem hiding this comment.
Thank you. I'll think a bit more about it.
Make it a bit less verbose.
dynamotn
reviewed
Jul 8, 2021
| if string match -q 'gitlab.com/*' \$name[1] | ||
| set bare (string replace 'gitlab.com/' '' \$name[1]) | ||
| set repo (string split '/' \$bare) | ||
| set url https://gitlab.com/{\$bare}/-/archive/{\$name[2]}/{\$repo[2]}-{\$name[2]}.tar.gz |
There was a problem hiding this comment.
It won't work with project in sub-group on Gitlab.
Like gitlab.com/config/fish/abc.git project.
You must change it to
set url https://gitlab.com/{\$bare}/-/archive/{\$name[2]}/{\$repo[-1]}-{\$name[2]}.tar.gzThere was a problem hiding this comment.
Thank you for catching this bug. 💯
Closed
|
I'd really like to have this, did your thinking bring something up? 😋 |
|
Available in 4.3.5. Thank you, @ainmosni. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to add plugins from gitlab. Resolves #657.