From a02b0d90867cd01afbfa56b2232b976b4d0ad31c Mon Sep 17 00:00:00 2001 From: Vladimir Kutepov Date: Thu, 1 Mar 2018 11:26:21 +0700 Subject: [PATCH] Falsey attributes --- src/index.js | 2 +- test/dom.test.js | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index ff9497376..fd2b7ff34 100644 --- a/src/index.js +++ b/src/index.js @@ -161,7 +161,7 @@ export function app(state, actions, view, container) { element.removeEventListener(name, eventListener) } } else if (name in element && name !== "list" && !isSvg) { - element[name] = value == null ? "" : value + element[name] = value == null || value === "false" ? "" : value } else if (value != null && value !== false) { element.setAttribute(name, value) } diff --git a/test/dom.test.js b/test/dom.test.js index fe5c7907e..533e86158 100644 --- a/test/dom.test.js +++ b/test/dom.test.js @@ -652,3 +652,10 @@ testVdomToHtml("events", [ html: `` } ]) + +testVdomToHtml("falsey attributes", [ + { + vdom: , + html: `` + } +])