New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format improvements #664

Merged
merged 2 commits into from Mar 26, 2018

Conversation

3 participants
@okwolf
Contributor

okwolf commented Mar 25, 2018

Since I'm using prettier in my editor with format on save enabled - I noticed that our configuration for prettier is sent as a command line argument instead of stored in the "prettier" property of our package.json (or we could have a .prettierrc if you'd rather add a new file). Having this encourages folks to keep auto format enabled in their editors, which will eliminate the problem of forgetting to format the code. I'm already using this config in @hyperapp/logger and @hyperapp/fx.

Also, some of the existing code wasn't formatted, so I'm including that fix.

okwolf added some commits Mar 25, 2018

move prettier config option outside of cli argument in script so othe…
…r tools can use it

i.e. format on save in editors

@okwolf okwolf added the Community label Mar 25, 2018

@okwolf okwolf requested a review from jorgebucaran Mar 25, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Mar 25, 2018

Codecov Report

Merging #664 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #664   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         161    161           
  Branches       50     50           
=====================================
  Hits          161    161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808f42d...eca4228. Read the comment docs.

codecov bot commented Mar 25, 2018

Codecov Report

Merging #664 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #664   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         161    161           
  Branches       50     50           
=====================================
  Hits          161    161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808f42d...eca4228. Read the comment docs.

@jorgebucaran jorgebucaran merged commit 538a93e into jorgebucaran:master Mar 26, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 808f42d...eca4228
Details
codecov/project 100% remains the same compared to 808f42d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jorgebucaran

This comment has been minimized.

Show comment
Hide comment
@jorgebucaran

jorgebucaran Mar 26, 2018

Owner

Thanks, @okwolf! 💯

Owner

jorgebucaran commented Mar 26, 2018

Thanks, @okwolf! 💯

@okwolf okwolf deleted the okwolf:format branch Mar 26, 2018

@Swizz

This comment has been minimized.

Show comment
Hide comment
@Swizz

Swizz Mar 26, 2018

Contributor

Which Prettier plugin are you using for your editor ? Prettier Now ?

Contributor

Swizz commented Mar 26, 2018

Which Prettier plugin are you using for your editor ? Prettier Now ?

@jorgebucaran

This comment has been minimized.

Show comment
Hide comment
@jorgebucaran
Owner

jorgebucaran commented Mar 26, 2018

I am using this one: https://github.com/prettier/prettier-vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment