Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #774

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
4 participants
@ricosmall
Copy link

commented Nov 1, 2018

fixed format mistakes

Update README.md
fixed format mistakes
@codecov-io

This comment has been minimized.

Copy link

commented Nov 1, 2018

Codecov Report

Merging #774 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #774   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         169    169           
  Branches       54     54           
=====================================
  Hits          169    169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d23a35...d34b75e. Read the comment docs.

@jorgebucaran jorgebucaran added the Docs label Nov 1, 2018

@jorgebucaran

This comment has been minimized.

Copy link
Owner

commented Nov 1, 2018

Thanks, @ricosmall! 👋

@jorgebucaran jorgebucaran merged commit b074354 into jorgebucaran:master Nov 1, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 0d23a35...d34b75e
Details
codecov/project 100% remains the same compared to 0d23a35
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -322,7 +322,7 @@ If you don't know all the attributes that you want to place in a component ahead

```jsx
const TodoList = ({ todos, toggle }) =>
todos.map(todo => <TodoItem {...todo} toggle={toggle} />)
(todos.map(todo => <TodoItem {...todo} toggle={toggle} />)

This comment has been minimized.

Copy link
@fuzetsu

fuzetsu Nov 1, 2018

wasn't the parentheses matching the one on the .map, I don't think it was wrong before.

This comment has been minimized.

Copy link
@jorgebucaran

jorgebucaran Nov 1, 2018

Owner

Thanks, @fuzetsu, you are right. My bad for not thoroughly checking @ricosmall's PR in detail.

Fixed in #775. 👋

jorgebucaran added a commit that referenced this pull request Nov 1, 2018

jorgebucaran added a commit that referenced this pull request Nov 1, 2018

docs: revert syntax error introduced in #774
Revert syntax error introduced in #774

@jorgebucaran jorgebucaran added the Invalid label Nov 1, 2018

Repository owner locked and limited conversation to collaborators Nov 1, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.