New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings comply vnode #787

merged 3 commits into from Dec 3, 2018


3 participants

nmpribeiro commented Dec 3, 2018

We really need null type, as React.Key has number and null, and if we can't have the same React.Key types, we cannot exted VNode from React.

Sorry @jorgebucaran we do need null...

[at-loader] ./node_modules/hyperapp/hyperapp.d.ts:101:15 
    TS2320: Interface 'Element' cannot simultaneously extend types 'VNode<any>' and 'ReactElement<any>'.
  Named property 'key' of types 'VNode<any>' and 'ReactElement<any>' are not identical. 

This comment has been minimized.

codecov-io commented Dec 3, 2018

Codecov Report

Merging #787 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #787   +/-   ##
  Coverage     100%   100%           
  Files           1      1           
  Lines         169    169           
  Branches       54     54           
  Hits          169    169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae7d86...6c7331f. Read the comment docs.

@jorgebucaran jorgebucaran merged commit 61addd8 into jorgebucaran:master Dec 3, 2018

2 checks passed

codecov/patch Coverage not affected when comparing 3ae7d86...6c7331f
codecov/project 100% remains the same compared to 3ae7d86

@nmpribeiro nmpribeiro deleted the nmpribeiro:fix_typings_comply_vnode branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment