Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Upgrade to ahash v0.8 #1271

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

benesch
Copy link
Contributor

@benesch benesch commented Oct 10, 2022

Hey @jorgecarleitao! Just looking to avoid a duplicate dependency downstream, and this looked to drop in easily.

@jorgecarleitao jorgecarleitao merged commit 7cd8c49 into jorgecarleitao:main Oct 11, 2022
@jorgecarleitao
Copy link
Owner

This broke main and I missed it somehow when approving :/

jorgecarleitao added a commit that referenced this pull request Oct 14, 2022
@jorgecarleitao
Copy link
Owner

I just reverted this until we can fix it - see #1274

@benesch
Copy link
Contributor Author

benesch commented Oct 14, 2022

Thanks for being so on top of it! #1274 seems to have passed tests, unlike this PR! Anything you need me to do?

@jorgecarleitao
Copy link
Owner

We need to fix the #1274 - it is failing to compile on wasm32

benesch added a commit to benesch/arrow2 that referenced this pull request Nov 13, 2022
This is a resubmission of jorgecarleitao#1271, which was reverted in 6e46651, due to
compilation errors with the wasm32 target. It builds on jorgecarleitao#1274 to fix
those compilation errors.

Closes jorgecarleitao#1274.
benesch added a commit to benesch/arrow2 that referenced this pull request Nov 13, 2022
This is a resubmission of jorgecarleitao#1271, which was reverted in 6e46651, due to
compilation errors with the wasm32 target. It builds on jorgecarleitao#1274 to fix
those compilation errors.

Closes jorgecarleitao#1274.

Co-authored-by: "Jorge C. Leitao" <jorgecarleitao@gmail.com>
@benesch benesch mentioned this pull request Nov 13, 2022
@benesch
Copy link
Contributor Author

benesch commented Nov 13, 2022

We need to fix the #1274 - it is failing to compile on wasm32

Ah, thanks! I believe I've fixed it in #1297.

benesch added a commit to benesch/arrow2 that referenced this pull request Nov 13, 2022
This is a resubmission of jorgecarleitao#1271, which was reverted in 6e46651, due to
compilation errors with the wasm32 target. It builds on jorgecarleitao#1274 to fix
those compilation errors.

Closes jorgecarleitao#1274.

Co-authored-by: "Jorge C. Leitao" <jorgecarleitao@gmail.com>
benesch added a commit to benesch/arrow2 that referenced this pull request Nov 13, 2022
This is a resubmission of jorgecarleitao#1271, which was reverted in 6e46651, due to
compilation errors with the wasm32 target. It builds on jorgecarleitao#1274 to fix
those compilation errors.

Closes jorgecarleitao#1274.

Co-authored-by: "Jorge C. Leitao" <jorgecarleitao@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants