Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added avro record names when converting arrow schema to avro #1279

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

Samrose-Ahmed
Copy link
Contributor

This PR fixes avro serialization by adding record names when converting Arrow schema to Avro schema.

Closes #1269

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Oct 24, 2022
Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thank you! 🙇

Left some minor comments but otherwise good to go!

src/io/avro/write/schema.rs Outdated Show resolved Hide resolved
src/io/avro/write/schema.rs Outdated Show resolved Hide resolved
src/io/avro/write/schema.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 83.12% // Head: 83.14% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b97ac93) compared to base (0ba4f8e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
+ Coverage   83.12%   83.14%   +0.01%     
==========================================
  Files         369      369              
  Lines       40180    40191      +11     
==========================================
+ Hits        33399    33415      +16     
+ Misses       6781     6776       -5     
Impacted Files Coverage Δ
src/io/avro/write/schema.rs 84.28% <100.00%> (+2.92%) ⬆️
src/io/ipc/read/file.rs 96.87% <0.00%> (ø)
src/array/utf8/mod.rs 85.67% <0.00%> (+0.91%) ⬆️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️
src/io/ipc/read/reader.rs 96.00% <0.00%> (+1.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao
Copy link
Owner

Could you rebase and run clippy? I think this is ready to merge :)

@Samrose-Ahmed
Copy link
Contributor Author

Thanks I've run clippy and fmt and updated.

@jorgecarleitao jorgecarleitao merged commit ee77f18 into jorgecarleitao:main Nov 23, 2022
@jorgecarleitao jorgecarleitao changed the title Add avro record names when converting arrow schema to avro Added avro record names when converting arrow schema to avro Nov 23, 2022
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
…eitao#1279)

add avro record names when converting arrow schema to avro
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
…eitao#1279)

add avro record names when converting arrow schema to avro
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avro schema: Invalid record names
2 participants