Permalink
Browse files

Bug #681912: Sparkle naively double-escapes enclosure URLs

  • Loading branch information...
1 parent 7baf505 commit 00b67269d69f311ce4dcc39437f1d8ac1825b383 @andymatuschak andymatuschak committed Nov 26, 2010
Showing with 2 additions and 1 deletion.
  1. +2 −1 SUAppcastItem.m
View
@@ -180,7 +180,8 @@ - (BOOL)isDeltaUpdate
[self setDate:[dict objectForKey:@"pubDate"]];
[self setItemDescription:[dict objectForKey:@"description"]];
- [self setFileURL:[NSURL URLWithString:[[enclosure objectForKey:@"url"] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]]];
+ NSString *fileURLString = [[[enclosure objectForKey:@"url"] stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
+ [self setFileURL:[NSURL URLWithString:fileURLString]];
[self setDSASignature:[enclosure objectForKey:@"sparkle:dsaSignature"]];
[self setVersionString:newVersion];

0 comments on commit 00b6726

Please sign in to comment.