New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocket trajectory example broken since v4.0.0 #1136

Closed
josdejong opened this Issue Jun 16, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@josdejong
Owner

josdejong commented Jun 16, 2018

I noticed that the rocket_trajectory_optimization.html example is broken since v4.0.0. I haven't looked into it yet, it probably has to do with changes in implicit mulitplication.

https://github.com/josdejong/mathjs/blob/master/examples/browser/rocket_trajectory_optimization.html

To reproduce: open the example, change

<script src="../../dist/math.js"></script>

to:

<script src="https://unpkg.com/mathjs@3.20.2/dist/math.js"></script> works
<script src="https://unpkg.com/mathjs@4.0.0/dist/math.js"></script> doesn't work

@ericman314 maybe it's easy for you to figure out the cause?

@josdejong josdejong added the bug label Jun 16, 2018

@josdejong

This comment has been minimized.

Owner

josdejong commented Jul 4, 2018

I've found the cause and fixed it. Two occurrences of implicit multiplication of which the behaviour was changed in v4.0.0.

@josdejong josdejong closed this in 41febe2 Jul 7, 2018

@josdejong

This comment has been minimized.

Owner

josdejong commented Jul 7, 2018

This is fixed now in v5.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment