New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expressions: objects can't be written multi-line #1328

Closed
jean-emmanuel opened this Issue Nov 20, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@jean-emmanuel
Contributor

jean-emmanuel commented Nov 20, 2018

Looks like the getTokenSkipNewLine function could be used here to allow multi-line objects. What do you think ?

@josdejong josdejong added the feature label Nov 21, 2018

@josdejong

This comment has been minimized.

Owner

josdejong commented Nov 21, 2018

Wow, good point. Never realized that this isn't supported right now, it would be really useful to allow multi line inside objects.

Anyone interested in creating a PR to improve this?

GHolk added a commit to GHolk/mathjs that referenced this issue Dec 6, 2018

Fix object literal enable multiple lines (josdejong#1328)
* Allow object literal expression be multiple lines

* Add test for multiple lines object literal

josdejong added a commit that referenced this issue Dec 6, 2018

Fix object literal enable multiple lines (#1328) (#1349)
* Allow object literal expression be multiple lines

* Add test for multiple lines object literal
@josdejong

This comment has been minimized.

Owner

josdejong commented Dec 9, 2018

This issue has been addressed by @GHolk, in v5.4.0 multi-line object contents can be used.

@josdejong josdejong closed this Dec 9, 2018

@jean-emmanuel

This comment has been minimized.

Contributor

jean-emmanuel commented Dec 9, 2018

Cool thanks @GHolk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment