New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nthRoot function fails in MSIE 11 #480

Closed
Frodojj opened this Issue Oct 12, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@Frodojj

Frodojj commented Oct 12, 2015

When math.nthRoot is called from Math.js version 2.3.0, MSIE 11 throws TypeError: Object doesn't support property or method 'isFinite'. This can be fixed easily with a simple polyfill from MDN (public domain):

Number.isFinite = Number.isFinite || function (value) {
    "use strict";
    return typeof value === "number" && isFinite(value);
};

@josdejong josdejong added the bug label Oct 12, 2015

@josdejong

This comment has been minimized.

Owner

josdejong commented Oct 12, 2015

Thanks for spotting this issue @Frodojj . The issue can be solved even simpler, by replacing Number.isFinite with isFinite, as we already know the variable is a number.

@Frodojj

This comment has been minimized.

Frodojj commented Oct 12, 2015

That is true. I used a polyfill in my project; because, I wanted to make as few changes to third party libraries as possible. Obviously that's not an issue here. Heh :-) Thank you very much for the great library and your development of it!

@Frodojj Frodojj closed this Oct 12, 2015

@Frodojj Frodojj reopened this Oct 12, 2015

@Frodojj Frodojj closed this Oct 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment