New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question related to implicit multiplication #621

Closed
sonnyk22 opened this Issue Mar 22, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@sonnyk22

sonnyk22 commented Mar 22, 2016

The implicit multiplication is working great for any of the nearly 1000 simple/complex test cases I have testes on the library so far. Today, I tried below expression which I want to ask you about.

Expression: ((43)(60)+(21)(80)+(16)(100))/(43+21+16)
MathJS: result: 18995.25
Other Calcs result: 73.25

Would you think this could be related to the parsing?

MathJS:
calc1

Google Calc:
calc2

@josdejong josdejong added the bug label Mar 22, 2016

@josdejong

This comment has been minimized.

Owner

josdejong commented Mar 22, 2016

Thanks for spotting this bug! I reduced it to (2)(3)+4 being parsed with the wrong precedence as
2 * (3 + 4) instead of (2 * 3) + 4. I've fixed it in the develop branch and will do a bug fix release asap.

@sonnyk22

This comment has been minimized.

sonnyk22 commented Mar 22, 2016

Thank you!

@josdejong josdejong closed this in 77736f5 Mar 24, 2016

@sonnyk22

This comment has been minimized.

sonnyk22 commented Mar 25, 2016

Worked fantastically! Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment