New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some unit aliases are broken #631

Closed
frankdugan3 opened this Issue Mar 29, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@frankdugan3

frankdugan3 commented Mar 29, 2016

I have not exhaustively tried all unit aliases, but several I would like to use appear to be broken:

1 year
  1 year
1 years
  Error: Undefined symbol years
1 month
  1 month
1 months
  Error: Undefined symbol months
1 week
  1 week
1 weeks
  Error: Undefined symbol weeks

Several definitions are missing from ALIASES in Unit.js:

seconds: 'second',
secs: 'second',
minutes: 'minute',
mins: 'minute',
hours: 'hour',
hr: 'hour',
hrs: 'hour',
days: 'day',

If these are being deprecated, then the docs should be updated to reflect this: http://mathjs.org/docs/datatypes/units.html#reference

@FSMaxB FSMaxB added the bug label Mar 30, 2016

@josdejong

This comment has been minimized.

Owner

josdejong commented Mar 31, 2016

Thanks, these three aliases where simply missing, I've added them.

@josdejong josdejong closed this in 5acdd96 Apr 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment