New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect interaction between access.js and array with bignumbers #856

Closed
30percent opened this Issue May 15, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@30percent

30percent commented May 15, 2017

I would expect: math.eval("[1,bignumber(2)][2]") === math.bignumber(2). Unfortunately, access.js calls .valueOf on the subset result for matrix requests. It is the only case of a valueOf call. Bignumber returns the string result on a valueOf call. It's not clear why matrices uniquely require a base value on result. It would seem to me we could just remove that call.

Reference link: access.js

@josdejong josdejong added the bug label May 16, 2017

@josdejong

This comment has been minimized.

Owner

josdejong commented May 16, 2017

Thanks for reporting Mark, this is a bug.

@josdejong

This comment has been minimized.

Owner

josdejong commented May 16, 2017

Has been fixed in the develop branch.

@josdejong josdejong closed this in f61bb6c May 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment