New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex transpose. A' now takes conjugate. #1097

Merged
merged 2 commits into from May 5, 2018

Conversation

Projects
None yet
2 participants
@jackschmidt
Contributor

jackschmidt commented May 2, 2018

As mentioned in #1094:

In matlab and octave the expression A' produces the Hermitian
conjugate, the complex conjugate of the transpose.

Now transpose produces the transpose, while ctranspose produces
the conjugate transpose. These are equal for real numbers, while
for complex numbers only the conjugate transpose is of much use.

Add complex transpose. A' now takes conjugate.
In matlab and octave the expression A' produces the Hermitian
conjugate, the complex conjugate of the transpose.

Now transpose produces the transpose, while ctranspose produces
the conjugate transpose. These are equal for real numbers, while
for complex numbers only the conjugate transpose is of much use.

@josdejong josdejong changed the base branch from develop to v5 May 5, 2018

@josdejong josdejong changed the base branch from v5 to develop May 5, 2018

@josdejong josdejong changed the base branch from develop to v5 May 5, 2018

@josdejong josdejong referenced this pull request May 5, 2018

Closed

Breaking changes for v5 #1045

7 of 7 tasks complete
@josdejong

This comment has been minimized.

Owner

josdejong commented May 5, 2018

Thanks a lot @jackschmidt , your code looks neat and well tested.

Maybe you can simply the function ctranspose to the following since transpose and conj itself handle checking Matrix/Array/scalar:

var ctranspose = typed('ctranspose', {
    'any': function (x) {
      return conj( transpose( x ) );
    }
});

I've changed the base or the PR to v5 since this is a breaking change, and added it to the list with breaking changes in #1045.

@jackschmidt

This comment has been minimized.

Contributor

jackschmidt commented May 5, 2018

Looks good to me. It should reduce code size with no real impact on execution speed.

@josdejong

This comment has been minimized.

Owner

josdejong commented May 5, 2018

Thanks for the update @jackschmidt , will merge your work now in the v5 branch.

@josdejong josdejong merged commit b5c3ff2 into josdejong:v5 May 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment