New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standard to the latest version 馃殌 #1226

Merged
merged 15 commits into from Sep 8, 2018

Conversation

Projects
None yet
2 participants
@greenkeeper
Contributor

greenkeeper bot commented Aug 29, 2018

Version 12.0.0 of standard was just published.

Dependency standard
Current Version 11.0.1
Type devDependency

The version 12.0.0 is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of standard.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don鈥檛 have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 91 commits.

  • ff1a156 authors
  • 17727fc 12.0.0
  • bdbd248 changelog
  • 3db3a62 https
  • cf1802c eslint-plugin-standard ~4.0.0
  • 7d779b8 eslint-plugin-import ~2.14.0
  • 66f676b eslint ~5.4.0
  • 3933c6b Use npm versions of eslint shared configs
  • c00dc66 Use ~ for eslint dep
  • 588d5ab Add links to French README translation!
  • aee57b4 ESLint 5
  • c89d5c7 Merge pull request #1145 from theo4u/patch-1
  • 6477dbf Merge pull request #1184 from standard/greenkeeper/babel-eslint-9.0.0
  • 8792b9b Merge pull request #1180 from standard/greenkeeper/eslint-plugin-promise-4.0.0
  • ff070b8 Merge branch 'master' into greenkeeper/eslint-plugin-promise-4.0.0

There are 91 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 馃尨

@greenkeeper greenkeeper bot added the greenkeeper label Aug 29, 2018

@josdejong

This comment has been minimized.

Owner

josdejong commented Aug 29, 2018

This is interesting, there are some changes in the standard so we should look into that.

@harrysarson

This comment has been minimized.

Collaborator

harrysarson commented Aug 29, 2018

Hopefully all changes would be covered by --fix

greenkeeper bot added a commit that referenced this pull request Aug 30, 2018

@greenkeeper

This comment has been minimized.

Contributor

greenkeeper bot commented Aug 30, 2018

Version 12.0.1 just got published.

Update to this version instead 馃殌

Commits

The new version differs by 8 commits.

See the full diff

harrysarson added some commits Sep 3, 2018

update to new lint version with --fix
I believe this mainly adds whitespace to `{}`'s.
Replace assert.equal with assert.strictEqual
This breaks a lot of tests which I will endevour to fix in the next
commits.
@harrysarson

This comment has been minimized.

Collaborator

harrysarson commented Sep 3, 2018

Node depreciated assert.equal, I have done a blanket find and replace to assert.strictEqual. There are a fair few test failures because of this which I hope to fix.

Note to self: don't forget to check use of assert.strictEquals in ./benchmarks. Edit: we are all good in ./benchmarks.

@josdejong

This comment has been minimized.

Owner

josdejong commented Sep 3, 2018

Thanks for picking this up Harry!

harrysarson added some commits Sep 4, 2018

Fix most errors due to assert.strictEquals
Some instances of `strictEquals` are replaced by `deepEquals`.
`toString` has been used to make some string comparisions explicit.
Tests will still fail untill #1236 and #1237 are fixed.
Fix assertion erros due to -0
With node 10, assert.strictEqual no longer considers `0 === -0`.
I missed these first time round as I was using node 8.
@harrysarson

This comment has been minimized.

Collaborator

harrysarson commented Sep 4, 2018

Getting there slowly 馃槃.

Failures are #1236, #1237 and the fact that Bignumber.acos has gone missing.

Put toString correct side of bracket
I was converting the constructor to a string rather
than the result of the computation. Oops.
@harrysarson

This comment has been minimized.

Collaborator

harrysarson commented Sep 4, 2018

Fixed the Bignumber.acos issue - I had made a typo.

@harrysarson

This comment has been minimized.

Collaborator

harrysarson commented Sep 4, 2018

This is now ready to merge.

Though, if we don't want failing tests in develop then we need to fix #1236 and #1237 before hitting merge.

josdejong added some commits Sep 4, 2018

@josdejong

This comment has been minimized.

Owner

josdejong commented Sep 8, 2018

I see there are more things reported by standard (changing deepEqual to deepStrictEqual etc), working on that now.

josdejong added some commits Sep 8, 2018

@josdejong

This comment has been minimized.

Owner

josdejong commented Sep 8, 2018

I think we're there now, awaiting Travis.

I had to change some values in unit test from 0 to -0. We may have to give this some more thought.

@josdejong

This comment has been minimized.

Owner

josdejong commented Sep 8, 2018

All green now 馃憤 thanks again Harry

@josdejong josdejong merged commit c5971b3 into develop Sep 8, 2018

4 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (josdejong) No new issues
Details

@greenkeeper greenkeeper bot deleted the greenkeeper/standard-12.0.0 branch Sep 8, 2018

@harrysarson

This comment has been minimized.

Collaborator

harrysarson commented Sep 8, 2018

Yay, nice work too @josdejong 馃帀馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment