New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to babel 7 #1234

Merged
merged 5 commits into from Sep 8, 2018

Conversation

Projects
None yet
2 participants
@harrysarson
Collaborator

harrysarson commented Sep 3, 2018

Hopefully this should get all the tests passing with babel 7.

This does what greenkeeper struggled with in #1224. Quite a few dependencies had to be simultaneously upgraded to make it work.

josdejong added some commits Sep 8, 2018

Merge branch 'develop' into babel@7
# Conflicts:
#	package-lock.json
@josdejong

This comment has been minimized.

Owner

josdejong commented Sep 8, 2018

The upgrade is almost complete. Last thing here is to fix issues in the generated bundle: it's not allowed to have files with mixed import (es6) and exports (commonjs). Looking into that right now.

@josdejong

This comment has been minimized.

Owner

josdejong commented Sep 8, 2018

🎉

@josdejong josdejong merged commit 5750a18 into develop Sep 8, 2018

4 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (josdejong) No new issues
Details

@josdejong josdejong deleted the babel@7 branch Sep 8, 2018

@josdejong

This comment has been minimized.

Owner

josdejong commented Sep 8, 2018

@harrysarson I'm really happy with our thorough unit tests, also for the bundles, because of that I immediately noticed that the bundles that where generated where broken.

@harrysarson

This comment has been minimized.

Collaborator

harrysarson commented Sep 8, 2018

Yeah, there is always room to improve of course but mathjs has very solid tests right now.

We can have a lot of confidence that passing tests mean a fully working library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment