New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling if webpack errors. #1374

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
2 participants
@harrysarson
Copy link
Collaborator

harrysarson commented Jan 5, 2019

It turns out webpack can error in two ways. This adds a check for the second way
and also surfaces any warnings.

Previously if webpack failed to build mathjs it silently failed and gulp crashed later on (when trying to minify).

See: https://webpack.js.org/api/node/#error-handling.

Improve error handling if webpack errors.
It turns out webpack can error in two ways. This adds a check for the second way
and also surfaces any warnings.
See: https://webpack.js.org/api/node/#error-handling.
@josdejong

This comment has been minimized.

Copy link
Owner

josdejong commented Jan 5, 2019

😲 good find, thanks for the fix!

@josdejong josdejong merged commit 1e2f3ed into develop Jan 5, 2019

4 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (josdejong) No new issues
Details

@josdejong josdejong deleted the better-gulp branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment