New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerical imprecision in complex square root #208

Merged
merged 2 commits into from Aug 12, 2014

Conversation

Projects
None yet
2 participants
@pavpanchekha
Contributor

pavpanchekha commented Aug 12, 2014

The expression used for complex square root returns imprecise results for negative reals. To avoid this imprecision, the equation is rearranged not to add r to x.re (which are of similar size and opposite sign).

josdejong added a commit that referenced this pull request Aug 12, 2014

Merge pull request #208 from pavpanchekha/develop
Numerical imprecision in complex square root

@josdejong josdejong merged commit 04a6cec into josdejong:develop Aug 12, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@josdejong

This comment has been minimized.

Owner

josdejong commented Aug 12, 2014

Thanks, nice improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment