New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isSafeProperty ghosting #899

Merged
merged 3 commits into from Jul 13, 2017

Conversation

Projects
None yet
2 participants
@ThomasBrierley
Contributor

ThomasBrierley commented Jul 12, 2017

Change condition for property ghosting to match desired behaviour as discussed in #888 :

  • Ghosting custom properties are allowed
  • Only ghosting properties on Function.prototype or Object.prototype are restricted
@josdejong

This comment has been minimized.

Owner

josdejong commented Jul 13, 2017

That makes sense indeed, smart and simple solution!

@josdejong josdejong merged commit b70ba60 into josdejong:develop Jul 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new vulnerabilities
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment