Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

could we have @glimmer/ depenencies as peer dependencies to avoid package duplication and conflicts? #50

Closed
lifeart opened this issue Oct 19, 2021 · 2 comments · Fixed by #56
Closed

could we have @glimmer/ depenencies as peer dependencies to avoid package duplication and conflicts? #50

lifeart opened this issue Oct 19, 2021 · 2 comments · Fixed by #56

Comments

@lifeart
Copy link
Contributor

lifeart commented Oct 19, 2021

Glimmer allow to have only one @glimmer/validator version in runtime and looks like @glimmer/owner also should be only one to prevent "loosing" ownership.

related issue: #48 (comment)
@josemarluedke
Copy link
Owner

That's an interesting idea. However, I only see a problem with duplicated validator when we have multiple versions of the Glimmer packages.

@josemarluedke josemarluedke mentioned this issue Jan 29, 2022
Merged
@josemarluedke
Copy link
Owner

Fixed in v0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to ESM only josemarluedke/glimmer-apollo
2 participants
@josemarluedke @lifeart