Joseph Bridgwater-Rowe josephbridgwaterrowe

  • Tulare, CA
  • Joined on

Organizations

@westernmilling
@josephbridgwaterrowe

Granted, this will probably be used... but I'm an advocate of YAGNI.

@josephbridgwaterrowe
  • 61a1740
    Simplify codebase and changes for apartment.
@josephbridgwaterrowe
@josephbridgwaterrowe
Fixes update record method
1 commit with 432 additions and 276 deletions
@josephbridgwaterrowe
Blanket not updating new knackhq fields
@josephbridgwaterrowe

Rebase and I will merge.

@josephbridgwaterrowe

Correct me if I'm wrong but this will now return an array?

@josephbridgwaterrowe

:gun:

@josephbridgwaterrowe

May I suggest replacing this with a direct call to request since the request_object only appears to be used once.

@josephbridgwaterrowe

I think thats better personally :).

@josephbridgwaterrowe

But the Knach API is still performing the same query? And the non info version still returns the same info as well as the objects?

@josephbridgwaterrowe

OK, thanks. What benefit does this provide over just a normal object query?

@josephbridgwaterrowe

What does this method return?

@josephbridgwaterrowe

Understood now with the complete return samples. Can you remind me why the monkey patch though, was it for the symbolizing? Which I would avoid and…

@josephbridgwaterrowe
@josephbridgwaterrowe
@josephbridgwaterrowe
@josephbridgwaterrowe

No, but you've changed the Blanket output :smile: Why monkey patch at all?

@josephbridgwaterrowe
@josephbridgwaterrowe

Also, I don't see the benefit in the Array around the hashes? Am I missing something?

@josephbridgwaterrowe

App data in public repo... I like it. :)

@josephbridgwaterrowe

So why are you monkey patching Blanket?

@josephbridgwaterrowe
@josephbridgwaterrowe

Can you remind me what the problem with the original Blanket implementation was?

@josephbridgwaterrowe
@josephbridgwaterrowe
@josephbridgwaterrowe

If the original implementation returns a single element Array with a RecursiveOpenStruct, what does this struct look like? Is there an attribute of…

@josephbridgwaterrowe
@josephbridgwaterrowe